Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo: consistency issue with probablyup/wait-for-netlify-action on main runs #6508

Closed
JamesHenry opened this issue Feb 21, 2023 · 2 comments
Closed

Repo: consistency issue with probablyup/wait-for-netlify-action on main runs #6508

JamesHenry opened this issue Feb 21, 2023 · 2 comments
Assignees
@JamesHenry
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JamesHenry
Copy link
Member

JamesHenry commented Feb 21, 2023 •
edited

This affects website tests on main runs.

Reported here: quantizor/wait-for-netlify-action#5
@JamesHenry JamesHenry added triage Waiting for maintainers to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Feb 21, 2023
@JoshuaKGoldberg
Copy link
Member

Example logs from #6554:

...
URL https://6400d50730c8b300086cd150--typescript-eslint.netlify.app unavailable, retrying...
URL https://6400d50730c8b300086cd150--typescript-eslint.netlify.app unavailable, retrying...
Error: Timeout reached: Unable to connect to https://6400d50730c8b300086cd150--typescript-eslint.netlify.app

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Mar 8, 2023
This was referenced Mar 8, 2023
Merged
Merged
@JamesHenry JamesHenry mentioned this issue Jun 4, 2023
Merged
@JamesHenry JamesHenry self-assigned this Jun 4, 2023
@JamesHenry
Copy link
Member Author

I have finally gotten around to resolving this by creating our own lightweight action within the repo:
https://github.com/typescript-eslint/typescript-eslint/blob/main/.github/actions/wait-for-netlify/index.js

Here are the tests passing on the latest main commit after that action went in in #7083:
https://github.com/typescript-eslint/typescript-eslint/actions/runs/5169175265/jobs/9311306701

NOTE: In the time that these tests have been disabled it seems that all the Playground ones stopped working, so I needed to skip them to proceed:
https://github.com/typescript-eslint/typescript-eslint/pull/7083/files#diff-2a06cb80e80a23b70ff5ed6cccd175ae80e657efbc6736d910d9f0e705fb7925R5

Hopefully somebody how is more familiar with the Playground can take a look

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesHenry JamesHenry

Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesHenry @JoshuaKGoldberg