Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-misused-promises] fix incorrect detection of void functions in JSX attributes #6638

Merged
merged 2 commits into from Mar 15, 2023

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

Dunno how this existed for so long!

@bradzacher bradzacher added the bug Something isn't working label Mar 15, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Mar 15, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 75500fc
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64112a61124bbf00075e3d49
😎 Deploy Preview https://deploy-preview-6638--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #6638 (75500fc) into main (9eafd87) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6638   +/-   ##
=======================================
  Coverage   85.15%   85.15%           
=======================================
  Files         383      383           
  Lines       13026    13026           
  Branches     3839     3839           
=======================================
  Hits        11092    11092           
  Misses       1572     1572           
  Partials      362      362           
Flag Coverage Δ
unittest 85.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts 97.47% <100.00%> (ø)

@bradzacher
Copy link
Member Author

need this for the v6 branch, so jumping the merge queue.

@bradzacher bradzacher merged commit 9e41cee into main Mar 15, 2023
36 of 38 checks passed
@bradzacher bradzacher deleted the 6637-nmu-jsx-bug branch March 15, 2023 22:17
hasparus pushed a commit to hasparus/typescript-eslint that referenced this pull request Mar 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-misused-promises] false positive with non-promise returning function in JSX
1 participant