Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [consistent-type-assertions] add suggestions for objectLiteralTypeAssertions #6642

Merged

Conversation

NotWoods
Copy link
Contributor

PR Checklist

Overview

Suggestions changes to code styled as const x = { ... } as T;.

Suggestions:

const x: T = { ... }; // autofix for variable declarators
const x = { ... } satisfies T; // autofix for TypeScript 4.9+

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @NotWoods!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Mar 15, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 25b710d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/641a0dd1457c230008b295d7
😎 Deploy Preview https://deploy-preview-6642--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #6642 (0fdac48) into main (f081bcd) will decrease coverage by 1.39%.
The diff coverage is n/a.

❗ Current head 0fdac48 differs from pull request most recent head 25b710d. Consider uploading reports for the commit 25b710d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6642      +/-   ##
==========================================
- Coverage   88.63%   87.24%   -1.39%     
==========================================
  Files         382      383       +1     
  Lines       12887    13083     +196     
  Branches     3789     3845      +56     
==========================================
- Hits        11422    11414       -8     
- Misses       1124     1302     +178     
- Partials      341      367      +26     
Flag Coverage Δ
unittest 87.24% <ø> (-1.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

@bradzacher bradzacher added the enhancement New feature or request label Mar 15, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core functionality change looks great to me, thanks!

Same comment as https://github.com/typescript-eslint/typescript-eslint/pull/6641/files#r1141148693 though: I worry about edge cases. Could you add some more testing around those syntax shenanigans please?

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Mar 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Mar 21, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 excellent, thanks for this one too!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 720e811 into typescript-eslint:main Mar 21, 2023
36 checks passed
@NotWoods NotWoods deleted the suggest-object-type-assertions branch March 21, 2023 20:27
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 28, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.56.0` -> `5.57.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.56.0/5.57.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.56.0` -> `5.57.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.56.0/5.57.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.57.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5570-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5560v5570-2023-03-27)

[Compare Source](typescript-eslint/typescript-eslint@v5.56.0...v5.57.0)

##### Bug Fixes

-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] simplify fixer and add support for double negation ([#&#8203;6620](typescript-eslint/typescript-eslint#6620)) ([81c8519](typescript-eslint/typescript-eslint@81c8519))
-   **eslint-plugin:** correct crashes with getTypeArguments for ts < 3.7 ([#&#8203;6767](typescript-eslint/typescript-eslint#6767)) ([59eab58](typescript-eslint/typescript-eslint@59eab58))

##### Features

-   **eslint-plugin:** \[consistent-type-assertions] add suggestions for objectLiteralTypeAssertions ([#&#8203;6642](typescript-eslint/typescript-eslint#6642)) ([720e811](typescript-eslint/typescript-eslint@720e811))
-   **eslint-plugin:** \[consistent-type-assertions] autofix angle bracket assertions to as ([#&#8203;6641](typescript-eslint/typescript-eslint#6641)) ([ad8ea64](typescript-eslint/typescript-eslint@ad8ea64))
-   **eslint-plugin:** add `no-duplicate-type-constituents` rule ([#&#8203;5728](typescript-eslint/typescript-eslint#5728)) ([bc31078](typescript-eslint/typescript-eslint@bc31078))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.57.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5570-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5560v5570-2023-03-27)

[Compare Source](typescript-eslint/typescript-eslint@v5.56.0...v5.57.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMjQuMiJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1831
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [consistent-type-assertions] Suggest alternate styles for objectLiteralTypeAssertions
3 participants