Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo: Merge codecov report from ast-spec into typescript-estree's report #6701

Open
JoshuaKGoldberg opened this issue Mar 20, 2023 · 1 comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

#6240 shows an example of a PR where changes in one package are given unit test coverage by changes in another package. Is that something we want factored into the codecov reports? At first I wanted it, but now I'm wondering if we should consider coverage just from within each package's own unit tests...

If we do want this, from @RebeccaStevens's #6240 (comment):

Codecov can merge multiple reports. I've already set this up in ts-api-utils to merge the reports from different TypeScript versions.

See https://docs.codecov.com/docs/flags for more details on how it works.

@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for maintainers to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Mar 20, 2023
@bradzacher
Copy link
Member

I think the only one we want to merge would be tests from ast-spec covering the code in typescript-estree - because those are the actual tests for that package!

However I don't think we would want our utility packages to be "covered" by the tests in eslint-plugin - implicit tests via usage seem like they aren't a great marker for test coverage.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Repo: Merge codecov reports between packages Repo: Merge codecov report from ast-spec into typescript-estree's report Mar 21, 2023
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

No branches or pull requests

2 participants