fix(eslint-plugin): correct crashes with getTypeArguments for ts < 3.7

[armano2]

PR Checklist

• Steps in Contributing were taken

Overview

Tested in playground on ts 3.5.1

TypeError: e.getTypeArguments is not a function
Occurred while linting <input>:4
Rule: "@typescript-eslint/no-unsafe-argument"
    at FunctionSignature.create (https://typescript-eslint.io/sandbox/index.js:20:1047289)
    at CallExpression, NewExpression (https://typescript-eslint.io/sandbox/index.js:20:1048838)
    at https://typescript-eslint.io/sandbox/index.js:20:259967
    at https://typescript-eslint.io/sandbox/index.js:20:250486
    at Array.forEach (<anonymous>)
    at Object.emit (https://typescript-eslint.io/sandbox/index.js:20:250474)
    at NodeEventGenerator$1.applySelector (https://typescript-eslint.io/sandbox/index.js:4:122618)
    at NodeEventGenerator$1.applySelectors (https://typescript-eslint.io/sandbox/index.js:4:122920)
    at NodeEventGenerator$1.enterNode (https://typescript-eslint.io/sandbox/index.js:4:123011)
    at CodePathAnalyzer$1.enterNode (https://typescript-eslint.io/sandbox/index.js:4:56566)

no-unsafe-argument

playground main
playground this branch

/*eslint "@typescript-eslint/no-unsafe-argument": "error"*/

declare function foo(...params: [number, string, any]): void;
foo(1, 'a', 1 as any);

no-misused-promises

playground main
playground this branch

/*eslint "@typescript-eslint/no-misused-promises": "error"*/

declare function foo(...params: [number]): void;
foo(1);

require-array-sort-compare

playground main
playground this branch

/*eslint "@typescript-eslint/require-array-sort-compare": ["error", { "ignoreStringArrays": true }] */

function f(a: string[]) {
  a.sort();
}

---

note: type rules are not working on ts 3.3 this is most likely related to playground bug tho

ref #1752

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	f678b6d
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/642130e61d09360008281fad
😎 Deploy Preview	https://deploy-preview-6767--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f678b6d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 25 targets

• Node 18 - nx test eslint-plugin
• Node 14 - nx test eslint-plugin --coverage=false
• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test type-utils
• Node 18 - nx test visitor-keys
• nx run-many --target=lint --parallel
• nx run-many --target=typecheck --parallel
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test ast-spec --coverage=false
• Node 18 - nx test eslint-plugin-internal
• Node 14 - nx test parser --coverage=false
• nx run-many --target=build --parallel --exclude website
• Node 18 - nx test parser
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx test typescript-estree --coverage=false
• Node 14 - nx test utils --coverage=false
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 18 - nx test scope-manager
• Node 18 - nx test typescript-estree
• Node 18 - nx test eslint-plugin-tslint
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 18 - nx test ast-spec

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #6767 (8f47a06) into main (f5631e9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 8f47a06 differs from pull request most recent head f678b6d. Consider uploading reports for the commit f678b6d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6767      +/-   ##
==========================================
+ Coverage   87.29%   87.33%   +0.03%     
==========================================
  Files         384      384              
  Lines       13139    13139              
  Branches     3859     3857       -2     
==========================================
+ Hits        11470    11475       +5     
+ Misses       1302     1298       -4     
+ Partials      367      366       -1     

Flag	Coverage Δ
unittest	87.33% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts	97.47% <100.00%> (ø)
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts	83.95% <100.00%> (ø)
...int-plugin/src/rules/require-array-sort-compare.ts	88.23% <100.00%> (ø)
packages/type-utils/src/isTypeReadonly.ts	88.00% <100.00%> (+2.00%)	⬆️

... and 1 file with indirect coverage changes

[bradzacher]

I think that this isn't really necessary any more - we're about to merge our v6 that will bump the minimum we'll past 3.7

Also given nobody has reported this it's probably not worth adding in the inconsistency into the codebase just to fill the gap for a few weeks? WDYT?

[armano2]

I think that this isn't really necessary any more - we're about to merge our v6 that will bump the minimum we'll past 3.7

Also given nobody has reported this it's probably not worth adding in the inconsistency into the codebase just to fill the gap for a few weeks? WDYT?

as we still support this in current version its better to fix this now, that have ppl ask about this in feature,

util.getTypeArguments should be removed / deprecated in v6

[bradzacher]

that have ppl ask about this in feature

That's kind of my point - 3.7 is 3 years old - so a lot of these have built up in the codebase over the last 3 years and I don't believe we've gotten one report about breakages.

There's some 250k weekly downloads for 3.7 versions (0.6% of the TS user base) and that number is likely dwindling. People aren't going to migrate onto 3.7 - and people that are using it certainly won't be using the latest version of our tooling.

Put another way - the intersection of people that are on the latest version of our tooling and the people that use TS3.7 is likely exactly 0.