Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: Add 'pnpm' tab alongside 'npm' and 'yarn' #6835

Closed
2 tasks done
JoshuaKGoldberg opened this issue Apr 3, 2023 · 4 comments
Closed
2 tasks done

Website: Add 'pnpm' tab alongside 'npm' and 'yarn' #6835

JoshuaKGoldberg opened this issue Apr 3, 2023 · 4 comments
Labels
enhancement New feature or request external This issue is with another package, not typescript-eslint itself package: website Issues related to the @typescript-eslint website

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Apr 3, 2023 •
edited

Before You File a Documentation Request Please Confirm You Have Done The Following...

Suggested Changes

pnpm is nice. I use it in all my new packages, and many users are switching to it. But, our guides just have npm and yarn tabs:

Screenshot of npm and yarn instructions in our getting started docs page

Let's add pnpm as a tab! 🚀

I don't know the best way to do this. Perhaps there's a dedicated package somewhere, or an option in an existing package we use?

This issue came out of a Twitch stream with @Jutanium. 👋

Affected URL(s)
@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website labels Apr 3, 2023
@armano2
Copy link
Member

armano2 commented Apr 3, 2023 •
edited

this has been added upstream, facebook/docusaurus#8690

see https://v6--typescript-eslint.netlify.app/getting-started/

@armano2 armano2 added external This issue is with another package, not typescript-eslint itself and removed accepting prs Go ahead, send a pull request that resolves this issue labels Apr 3, 2023
@JoshuaKGoldberg
Copy link
Member Author

@armano2 my hero!!

@armano2
Copy link
Member

armano2 commented Apr 3, 2023 •
edited

I think we can close it as fixed in v6

image

@JoshuaKGoldberg
Copy link
Member Author

👍 can confirm, thanks! cc @Jutanium: https://v6--typescript-eslint.netlify.app/ -> https://v6--typescript-eslint.netlify.app/getting-started#step-1-installation

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request external This issue is with another package, not typescript-eslint itself package: website Issues related to the @typescript-eslint website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armano2 @JoshuaKGoldberg