fix(type-utils): treat intrinsic types as if they are from lib and never match error types

[RebeccaStevens]

PR Checklist

• Addresses an existing open issue: fixes Bug: v6 typeMatchesSpecifier LibSpecifier should return true for intrinsic types (string, number, boolean, etc) #6867
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Adds explicit logic for intrinsic types and error types.

[typescript-eslint]

Thanks for the PR, @RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	e04ca7b
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64a78d16ccbf7b0008ee8313
😎 Deploy Preview	https://deploy-preview-6869--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[RebeccaStevens]

@marekdedic

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e04ca7b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 31 targets

• Node 16 - nx test visitor-keys --coverage=false
• Node 16 - nx run types:build
• Node 20 - nx test eslint-plugin
• Node 16 - nx test eslint-plugin --coverage=false
• nx run-many --target=lint --parallel
• Node 20 - nx test scope-manager
• Node 20 - nx test typescript-estree
• Node 20 - nx test utils
• Node 20 - nx run types:build
• Node 20 - nx test type-utils
• Node 20 - nx test visitor-keys
• Node 20 - nx test rule-schema-to-typescript-types
• Node 20 - nx test repo-tools
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test parser
• Node 20 - nx test ast-spec
• Node 20 - nx test eslint-plugin-tslint
• Node 16 - nx test typescript-estree --coverage=false
• nx run integration-tests:test
• nx run-many --target=typecheck --parallel
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx test parser --coverage=false
• nx run types:build
• Node 16 - nx test utils --coverage=false
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• Node 16 - nx test ast-spec --coverage=false
• Node 16 - nx test eslint-plugin-internal --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test repo-tools --coverage=false
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[marekdedic]

Hmm, good catch that native types aren't covered... Treating them as being from a lib is a bit of a simplification, but I think it's OK.

Not a maintainer, but could you please add a test?

[codecov]

Codecov Report

Merging #6869 (86372df) into v6 (e6235bf) will decrease coverage by 0.25%.
The diff coverage is 60.00%.

❗ Current head 86372df differs from pull request most recent head 0990cf6. Consider uploading reports for the commit 0990cf6 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##               v6    #6869      +/-   ##
==========================================
- Coverage   87.70%   87.46%   -0.25%     
==========================================
  Files         372      374       +2     
  Lines       12813    12887      +74     
  Branches     3795     3812      +17     
==========================================
+ Hits        11238    11271      +33     
- Misses       1199     1231      +32     
- Partials      376      385       +9     

Flag	Coverage Δ
unittest	87.46% <60.00%> (-0.25%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/type-utils/src/TypeOrValueSpecifier.ts	83.87% <60.00%> (-6.46%)	⬇️

... and 40 files with indirect coverage changes

[JoshuaKGoldberg]

Yup seems reasonable so far, but I'll take a closer look once there's some test coverage. 👍

[JoshuaKGoldberg]

Great, thanks @RebeccaStevens! 🚀

[marekdedic]

I'd like to see one more test for error types, otherwise LGTM, thanks!

[JoshuaKGoldberg]

@RebeccaStevens is this still something you have time to look into soon? No worries if not, I can touch things up myself tomorrow / this weekend in preparation for v6 (currently scheduled for Monday!).

[RebeccaStevens]

I just rebase this PR off the latest v6 branch and updated ts-api-utils.
I think everything should be ready to go now.

Let me know if there is anything else that needs doing.

[JoshuaKGoldberg]

💯 woop!