Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [strict-boolean-expressions] add ignoreRhs option #691

Merged
merged 1 commit into from Jul 24, 2019

Conversation

Retsam
Copy link
Contributor

@Retsam Retsam commented Jul 10, 2019

Adds an ignoreRhs option, to match the equivalent option in the tslint version of this rule.

This is a particularly good option to have for react code where stuff like this is idiomatic:

function MyComponent() {
    const shouldRenderFoo: boolean = /*...*/;
    return (<div>
          {shouldRenderFoo && <span>Foo</span>}
          <span>Bar</span>
    </div>);
}

Fixes #691

Adds an ignoreRhs option, to match the equivalent option in the tslint version of this rule
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #691 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   94.33%   94.34%   +<.01%     
==========================================
  Files         111      111              
  Lines        4593     4594       +1     
  Branches     1268     1269       +1     
==========================================
+ Hits         4333     4334       +1     
  Misses        149      149              
  Partials      111      111
Impacted Files Coverage Δ
...int-plugin/src/rules/strict-boolean-expressions.ts 100% <100%> (ø) ⬆️

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Jul 17, 2019
@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Jul 17, 2019
@bradzacher
Copy link
Member

LGTM - thanks for your contribution

@glen-84
Copy link
Contributor

glen-84 commented Jul 25, 2019

I apologize for commenting on a closed PR, but the Fixes issue number is incorrect.

@bradzacher
Copy link
Member

hahah thank you. I linked to itself.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants