feat(eslint-plugin): [restrict-plus-operands] change checkCompoundAssignments to skipCompoundAssignments

[JoshuaKGoldberg]

BREAKING CHANGE:
Renames an option for restrict-plus-operands

PR Checklist

• Addresses an existing open issue: fixes Enhancement: [restrict-plus-operands] Enable checkCompoundAssignments by default #6851
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Renames the option, so that the default state of off means we lint +=s.

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

❌ Deploy Preview for typescript-eslint failed.

Name	Link
🔨 Latest commit	340775d
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6483d7fdfbf28e00075f311c

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 340775d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

🟥 Failed Commands
Node 14 - nx test eslint-plugin --coverage=false

✅ Successfully ran 56 targets

• Node 20 - nx test eslint-plugin
• Node 16 - nx test eslint-plugin --coverage=false
• nx run-many --target=lint --parallel
• Node 20 - nx test typescript-estree
• Node 20 - nx test scope-manager
• nx run-many --target=build --projects=website-eslint,website
• Node 20 - nx test type-utils
• Node 20 - nx run types:build
• Node 20 - nx test visitor-keys
• Node 20 - nx test utils
• nx run-many --target=typecheck --parallel
• Node 20 - nx test parser
• Node 20 - nx test rule-schema-to-typescript-types
• Node 20 - nx test repo-tools
• Node 16 - nx test typescript-estree --coverage=false
• nx run integration-tests:test
• Node 20 - nx test eslint-plugin-tslint
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx test eslint-plugin-internal --coverage=false
• nx run types:build
• Node 16 - nx run types:build
• Node 16 - nx test ast-spec --coverage=false
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test ast-spec
• Node 16 - nx test parser --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• Node 16 - nx test repo-tools --coverage=false
• Node 16 - nx test visitor-keys --coverage=false
• Node 16 - nx test utils --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• Node 18 - nx test scope-manager
• Node 18 - nx test typescript-estree
• Node 18 - nx test utils
• Node 18 - nx test parser
• Node 18 - nx run types:build
• Node 18 - nx test type-utils
• Node 18 - nx test visitor-keys
• Node 18 - nx test repo-tools
• Node 14 - nx test typescript-estree --coverage=false
• Node 18 - nx test rule-schema-to-typescript-types
• Node 18 - nx test ast-spec
• Node 18 - nx test eslint-plugin-internal
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx run types:build
• Node 14 - nx test parser --coverage=false
• Node 18 - nx test eslint-plugin-tslint
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx test repo-tools --coverage=false
• Node 14 - nx test utils --coverage=false
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx test rule-schema-to-typescript-types --coverage=false

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #7027 (340775d) into v6 (fb66d33) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##               v6    #7027      +/-   ##
==========================================
- Coverage   87.70%   87.69%   -0.01%     
==========================================
  Files         372      372              
  Lines       12813    12813              
  Branches     3795     3795              
==========================================
- Hits        11238    11237       -1     
  Misses       1199     1199              
- Partials      376      377       +1     

Flag	Coverage Δ
unittest	87.69% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../eslint-plugin/src/rules/restrict-plus-operands.ts	86.53% <100.00%> (-1.93%)	⬇️

[bradzacher]

I don't know if renaming it is overall super high value given the disruptive nature of the change. We do have precedence for "truthy-by-default" options like the options in strict-boolean-expressions.

I'll leave it up to you.

[JoshuaKGoldberg]

Hmm yeah I see what you mean... I think the fact that we're turning on the behavior by default in the new config makes me feel better about it. Also not that many folks enable the option: https://sourcegraph.com/search?q=context:global+checkCompoundAssignments+lang:js+-file:node_modules&patternType=standard&sm=0&groupBy=path (current result count: 58).