Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: use graphemer instead of grapheme-splitter #7068

Closed
4 tasks done
oceandrama opened this issue May 27, 2023 · 0 comments · Fixed by #7069
Closed
4 tasks done

Enhancement: use graphemer instead of grapheme-splitter #7068

oceandrama opened this issue May 27, 2023 · 0 comments · Fixed by #7069
Labels
enhancement New feature or request triage Waiting for maintainers to take a look

Comments

@oceandrama
Copy link
Contributor

oceandrama commented May 27, 2023 •
edited

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

eslint-plugin

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

Since v8.41.0 eslint used graphemer instead of grapheme-splitter

It would be great to switch to it too for dependency deduplication. It also fixes some bugs with emoji

I will be glad to help with PR
@oceandrama oceandrama added enhancement New feature or request triage Waiting for maintainers to take a look labels May 27, 2023
@oceandrama oceandrama mentioned this issue May 27, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request triage Waiting for maintainers to take a look
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use graphemer instead of grapheme-splitter oceandrama/typescript-eslint
1 participant
@oceandrama