Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo: Add a way to detect breakages from new TS versions sooner #7093

Open
JoshuaKGoldberg opened this issue Jun 8, 2023 · 2 comments
Open
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Splitting out from microsoft/typescript-error-deltas#119 (comment), courtesy of #7088: is there a way we can be informed of issues from new Typescript packages sooner?

I'd love to get to a point where we always spin up a feature branch whenever there's an RC/beta, but historically it's been hard to find maintainer time consistently...

@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for maintainers to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Jun 8, 2023
@jakebailey
Copy link
Collaborator

Effectively, I was just thinking about adding to your CI a nightly scheduled run, plus an if-'d task which installs typescript@next. That way, the nightly run will fail and give you some early warning.

Something kinda like what I do in hereby to make sure that if my package is installed without a lockfile that things work:

https://github.com/jakebailey/hereby/blob/d9b8347923e3b098d00affdc4baa725aff00f9db/.github/workflows/ci.yml#L33-L38

@bradzacher
Copy link
Member

Maybe something like #1752 would help? I.e. once we can test old versions - it seems logical we could use the same infra to install the nightly TS version instead and run it (perhaps in a job that runs weekly or something to reduce noise?)

I remember we also talked about having a job that ran regularly against the latest tag for both ESLint and TS to ensure nothing breaks on the newer version (because we don't always update with minor ESLint versions or TS patch versions). I can't find an issue for it but I remember it... Something vaguely on that line is mentioned in #6456

@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

No branches or pull requests

3 participants