Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): move typescript from peer dep to dev dep #712

Merged
merged 1 commit into from Jul 18, 2019
Merged

fix(utils): move typescript from peer dep to dev dep #712

merged 1 commit into from Jul 18, 2019

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Jul 17, 2019

Done in https://github.com/typescript-eslint/typescript-eslint/pull/535/files#diff-5c11193544492a7547f43d5531701d83 so hopefully fine on its own as well 馃檪

This makes sure we don't get a peer dep warning if an eslint plugin depends on the utils to author the rules but do not need TS when running

@SimenB SimenB mentioned this pull request Jul 17, 2019
Merged
@bradzacher bradzacher added the bug Something isn't working label Jul 18, 2019
@bradzacher bradzacher merged commit f949355 into typescript-eslint:master Jul 18, 2019
@SimenB SimenB deleted the patch-1 branch July 18, 2019 16:16
@JamesHenry JamesHenry mentioned this pull request Jul 21, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimenB @bradzacher