Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): final final config changes for v6 #7157

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Applies the suggested config changes from the discussion.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Jul 1, 2023
@netlify
Copy link

netlify bot commented Jul 1, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 15c987c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64a449163f331e00076a2701
😎 Deploy Preview https://deploy-preview-7157--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 1, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 15c987c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@@ -17,7 +17,7 @@ export default util.createRule<Options, MessageIds>({
type: 'suggestion',
docs: {
description: 'Disallow the `any` type',
recommended: 'strict',
recommended: 'recommended',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v happy with this!

@@ -145,7 +145,7 @@ export default util.createRule<Options, MessageId>({
allowNullableBoolean: false,
allowNullableString: false,
allowNullableNumber: false,
allowNullableEnum: true,
allowNullableEnum: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is much safer so happy to see this!

@JoshuaKGoldberg JoshuaKGoldberg merged commit e35c5c1 into typescript-eslint:v6 Jul 4, 2023
43 of 46 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the v6-final-final-config-changes branch July 4, 2023 16:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants