Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): always return parserServices #716

Merged
merged 16 commits into from May 10, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Jul 18, 2019

BREAKING CHANGE:

previously plugins expected that parserServices would be undefined if full type information wasn't available.

Splitting these changes out of #688 to focus that PR.
The motivation behind this is that this will allow rules to consume diagnostics without needing the user to provide project, which slows down linting.

@bradzacher bradzacher added enhancement New feature or request breaking change This change will require a new major version to be released labels Jul 18, 2019
@bradzacher bradzacher force-pushed the expose-parserServices-always branch from b9205ac to 89c81a5 Compare July 18, 2019 00:24
BREAKING: previously plugins expected that `parserServices` would be `undefined` if full type information wasn't available.
@bradzacher bradzacher force-pushed the expose-parserServices-always branch from 89c81a5 to 01de581 Compare July 18, 2019 00:28
@bradzacher bradzacher changed the title feat: always return parserServices, add getParserServices from utils feat!: always return parserServices, add getParserServices from utils Jul 21, 2019
@bradzacher bradzacher requested review from JamesHenry and removed request for JamesHenry July 30, 2019 03:45
@bradzacher bradzacher added this to the 3.0.0 milestone Aug 7, 2019
@bradzacher bradzacher changed the title feat!: always return parserServices, add getParserServices from utils feat: always return parserServices, add getParserServices from utils Oct 8, 2019
@armano2
Copy link
Member

armano2 commented Jan 13, 2020

@bradzacher are you planning to resolve conflicts or do you want me to pick it up?

@bradzacher
Copy link
Member Author

bradzacher commented Jan 13, 2020

I was planning on getting back to it eventually, but it's been at a lower priority, because 3.0.0 was so far out 😅.

If you get the gist of what I was intending, then feel free to pick this up and get it ready for 3.0.0. I'd appreciate it 😄.

One important note: no-unused-vars-experimental will not require the complete type information with this change, so you should update that rule as part of this PR.

bradzacher and others added 2 commits January 14, 2020 22:50
BREAKING: previously plugins expected that `parserServices` would be `undefined` if full type information wasn't available.
Conflicts:
	packages/eslint-plugin-tslint/src/rules/config.ts
	packages/eslint-plugin/tools/validate-docs/validate-table-rules.ts
	packages/experimental-utils/src/eslint-utils/getParserServices.ts
	packages/typescript-estree/src/parser-options.ts
	packages/typescript-estree/src/parser.ts
	packages/typescript-estree/src/tsconfig-parser.ts
	packages/typescript-estree/tests/lib/convert.ts
	packages/typescript-estree/tests/lib/parse.ts
@armano2 armano2 changed the title feat: always return parserServices, add getParserServices from utils feat: always return parserServices Jan 14, 2020
Conflicts:
	packages/eslint-plugin/README.md
	packages/eslint-plugin/tests/docs.test.ts
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #716 into v3 will decrease coverage by 0.08%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##               v3     #716      +/-   ##
==========================================
- Coverage   93.87%   93.78%   -0.09%     
==========================================
  Files         172      172              
  Lines        7805     7809       +4     
  Branches     2240     2243       +3     
==========================================
- Hits         7327     7324       -3     
- Misses        221      227       +6     
- Partials      257      258       +1     
Flag Coverage Δ
#unittest 93.78% <56.25%> (-0.09%) ⬇️
Impacted Files Coverage Δ
...es/eslint-plugin/src/configs/eslint-recommended.ts 100.00% <ø> (ø)
...mental-utils/src/eslint-utils/getParserServices.ts 18.18% <0.00%> (-15.16%) ⬇️
...-estree/src/create-program/createProjectProgram.ts 92.68% <ø> (-0.18%) ⬇️
...ges/typescript-estree/src/create-program/shared.ts 88.57% <ø> (ø)
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts 80.17% <50.00%> (ø)
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.40% <100.00%> (ø)
...nt-plugin/src/rules/no-unused-vars-experimental.ts 91.48% <100.00%> (ø)
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts 100.00% <100.00%> (ø)
packages/typescript-estree/src/ast-converter.ts 100.00% <100.00%> (ø)
packages/typescript-estree/src/convert.ts 99.15% <100.00%> (ø)
... and 3 more

@bradzacher bradzacher changed the title feat: always return parserServices feat(typescript-estree): always return parserServices May 9, 2020
@bradzacher bradzacher merged commit fbc049a into v3 May 10, 2020
@bradzacher bradzacher deleted the expose-parserServices-always branch May 10, 2020 00:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants