fix(eslint-plugin): [no-var-requires] error if parent is CallExpression #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throwing error if the parent is CallExpression in no-var-requires plugin Closes: typescript-eslint#665
bradzacher
changed the title
|
Could you please add tests for this? |
|
Sure, i will add test cases and update the PR |
Adding a missing test case after handling new edge case Closes: typescript-eslint#665
|
Hi @bradzacher I have added the missing test case, sorry for the delay 😅 |
bradzacher
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing error if the parent is CallExpression in no-var-requires plugin
Closes: #665