Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add support for object props in CallExpressions #728

Merged
merged 5 commits into from Jul 24, 2019

Conversation

bradzacher
Copy link
Member

This is a blocker for turning on the rule in #535

Otherwise it reports for every single rule creation, even though they are strictly typed

export default util.createRule({
  create(context) { // Rule.RuleListener
    //...
  },
});

@bradzacher bradzacher added the enhancement New feature or request label Jul 19, 2019
JamesHenry
JamesHenry previously approved these changes Jul 24, 2019
@JamesHenry
Copy link
Member

Formatting is failing

@bradzacher
Copy link
Member Author

for one of my other branches I had the new version of prettier installed... which has a breaking change which adds a comma after tuple types.. grrr

@JamesHenry JamesHenry merged commit 8141f01 into master Jul 24, 2019
@JamesHenry JamesHenry deleted the efrt-object-prop-in-call branch July 24, 2019 23:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants