feat(eslint-plugin)!: change recommended config

[bradzacher]

BREAKING CHANGE: recommended config changes are considered breaking

See #651 for more info about what was included and why

Fixes #651
Fixes #433
Fixes #201
Fixes #493
Fixes #759
Fixes #822

[codecov]

Codecov Report

Merging #729 into master will decrease coverage by 0.01%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
- Coverage   94.21%   94.19%   -0.02%     
==========================================
  Files         112      112              
  Lines        4821     4825       +4     
  Branches     1336     1338       +2     
==========================================
+ Hits         4542     4545       +3     
- Misses        159      160       +1     
  Partials      120      120

Impacted Files	Coverage Δ
.../eslint-plugin/src/rules/no-useless-constructor.ts	100% <ø> (ø)	⬆️
...ackages/eslint-plugin/src/rules/prefer-includes.ts	100% <ø> (ø)	⬆️
packages/eslint-plugin/src/rules/ban-types.ts	100% <ø> (ø)	⬆️
packages/parser/src/scope/scope-manager.ts	100% <ø> (ø)	⬆️
...ages/eslint-plugin/src/rules/no-require-imports.ts	100% <ø> (ø)	⬆️
...slint-plugin/src/rules/no-unnecessary-qualifier.ts	96.07% <ø> (ø)	⬆️
...ges/eslint-plugin/src/rules/no-misused-promises.ts	100% <ø> (ø)	⬆️
packages/eslint-plugin-tslint/src/custom-linter.ts	100% <ø> (ø)	⬆️
.../eslint-plugin/src/rules/triple-slash-reference.ts	90% <ø> (ø)	⬆️
...kages/eslint-plugin/src/rules/class-name-casing.ts	85.71% <ø> (ø)	⬆️
... and 60 more

[glen-84]

@bradzacher Should the documentation also be updated?

[JamesHenry]

This contains some important updates to defaults of rules etc, and in general has a large diff, so I'm going to merge it and make the updates we discussed in a follow up.

Thanks again for doing this!

[bbugh]

Is there a full list of what was removed? We upgraded to the latest 2.x release from 1.x and notice a bunch of stuff (like no-console) that we rely on was removed, but I've looked through this issue and the PRs and I don't see a comprehensive list.

We'd like to put the recommended ones back in because we have a huge code base that relied on them. Thank you!

[bradzacher]

@bbugh
You're probably looking for eslint's recommended list, which changed between eslint 5 and eslint 6:
https://github.com/eslint/eslint/blob/master/conf/eslint-recommended.js

We only change our configs, which are found here:
https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin/src/configs

If you look at #651, you'll see an in-depth list of every single rule, and why or why not it was included in our v2 list.

---

As an aside, have a look at my personal config repo:
https://github.com/bradzacher/eslint-config-brad

In there I have tooling which strictly types config files to ensure I'm configuring rules correctly, and to ensure that I've configured every single available rule.

I strongly recommend that any appropriately large codebase should take ownership of their eslint config, and think about every single rule.

It will take a few hours to do e2e, sure, but the wins in terms of strict code style, error catching, etc are completely worth it for a large project.