Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin)!: add rule consistent-type-assertions #731

Merged
merged 8 commits into from Jul 25, 2019
Merged

feat(eslint-plugin)!: add rule consistent-type-assertions #731

merged 8 commits into from Jul 25, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Jul 20, 2019 •
edited

BREAKING CHANGE: Merges both no-angle-bracket-type-assertion and no-object-literal-type-assertion into one rule

Fixes #332
Fixes #668

@bradzacher
feat(eslint-plugin): add rule consistent-type-assertions
720b624 
Merges both `no-angle-bracket-type-assertion` and `no-object-literal-type-assertion` into one rule
Fixes #332
Fixes #668
@bradzacher bradzacher added the enhancement: new plugin rule New rule request for eslint-plugin label Jul 20, 2019
@bradzacher bradzacher mentioned this pull request Jul 20, 2019
Closed
14 tasks
@bradzacher bradzacher added this to the 2.0.0 milestone Jul 20, 2019
This was referenced Jul 20, 2019
Merged
Closed
@JamesHenry JamesHenry added the breaking change This change will require a new major version to be released label Jul 21, 2019
@bradzacher bradzacher changed the title feat(eslint-plugin): add rule consistent-type-assertions feat(eslint-plugin)!: add rule consistent-type-assertions Jul 22, 2019
@JamesHenry
Copy link
Member

@bradzacher Linting failed on this one, looks like we are still using the deleted rules as of the current commit, so it is failing to find them

@bradzacher
Copy link
Member Author

oops forgot about the recommended config

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #731 into master will decrease coverage by 0.13%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   94.47%   94.34%   -0.14%     
==========================================
  Files         112      111       -1     
  Lines        4721     4735      +14     
  Branches     1307     1315       +8     
==========================================
+ Hits         4460     4467       +7     
- Misses        150      156       +6     
- Partials      111      112       +1
Impacted Files Coverage Δ
...l-utils/src/eslint-utils/batchedSingleLineTests.ts 0% <0%> (ø) ⬆️
packages/eslint-plugin/src/rules/index.ts 100% <100%> (ø) ⬆️
...int-plugin/src/rules/consistent-type-assertions.ts 87.09% <87.09%> (ø)

@JamesHenry JamesHenry merged commit 92e98de into master Jul 25, 2019
@JamesHenry JamesHenry deleted the consistent-type-assertions branch July 25, 2019 00:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry left review comments

Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Milestone
2.0.0
2 participants
@bradzacher @JamesHenry