Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin)!: [promise-function-async] make allowAny default true #733

Merged
merged 2 commits into from Jul 21, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Jul 20, 2019

BREAKING CHANGE: changing default rule config

Having functions that return any be considered async is weird. I left the option in just in case someone wants this functinoality.
#501 (comment)

@bradzacher bradzacher added enhancement New feature or request breaking change This change will require a new major version to be released labels Jul 20, 2019
@bradzacher bradzacher added this to the 2.0.0 milestone Jul 20, 2019
@bradzacher bradzacher mentioned this pull request Jul 20, 2019
14 tasks
@bradzacher bradzacher changed the title feat(eslint-plugin): [promise-function-async] make allowAny default true feat(eslint-plugin)!: [promise-function-async] make allowAny default true Jul 21, 2019
@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #733 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
- Coverage   94.45%   94.41%   -0.04%     
==========================================
  Files         113      113              
  Lines        4705     4711       +6     
  Branches     1288     1293       +5     
==========================================
+ Hits         4444     4448       +4     
  Misses        150      150              
- Partials      111      113       +2
Impacted Files Coverage Δ
.../eslint-plugin/src/rules/promise-function-async.ts 100% <ø> (ø) ⬆️
packages/eslint-plugin/src/util/misc.ts 80.95% <0%> (-3.26%) ⬇️
...-plugin/src/rules/explicit-member-accessibility.ts 88.23% <0%> (-1.35%) ⬇️
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.39% <0%> (ø) ⬆️
...-plugin/src/rules/explicit-function-return-type.ts 100% <0%> (ø) ⬆️
packages/eslint-plugin/src/rules/array-type.ts 91.35% <0%> (ø) ⬆️
...ges/experimental-utils/src/ts-eslint/RuleTester.ts 0% <0%> (ø) ⬆️

@JamesHenry JamesHenry merged commit 590ca50 into master Jul 21, 2019
@JamesHenry JamesHenry deleted the pfa-default-opts branch July 21, 2019 22:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants