Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [prefer-nullish-coalescing] allow ignorePrimitives option to be true #7331

Merged
merged 2 commits into from Aug 5, 2023

Conversation

auvred
Copy link
Member

@auvred auvred commented Jul 27, 2023

PR Checklist

Overview

Not sure if I need to add an invalid tests case for such a change

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4b906b3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64c299eee7acfd000818e942
😎 Deploy Preview https://deploy-preview-7331--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 27, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4b906b3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the enhancement New feature or request label Jul 28, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 super, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit dfcafae into typescript-eslint:main Aug 5, 2023
46 of 47 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [prefer-nullish-coalescing] Allow ignorePrimitives option to be true
3 participants