fix(eslint-plugin): [strict-boolean-expressions] replace dangerous fixer with suggestions

[kemilbeltre]

Remove explicit rule check for logical negation expressions

PR Checklist

• Addresses an existing open issue: fixes Bug: @typescript-eslint/strict-boolean-expressions breaks code on --fix #7312
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @kemilbeltre!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	102eefc
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64d21f870947ca00089ba547
😎 Deploy Preview	https://deploy-preview-7394--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 102eefc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 37 targets

• nx test eslint-plugin --coverage=false
• Node 20 - nx test eslint-plugin
• Node 16 - nx test eslint-plugin --coverage=false
• nx build website
• nx test eslint-plugin-tslint --coverage=false
• nx run types:build
• nx test typescript-estree --coverage=false
• nx test eslint-plugin-internal --coverage=false
• Node 20 - nx test type-utils
• Node 20 - nx run types:build
• Node 20 - nx test typescript-estree
• Node 20 - nx test utils
• Node 20 - nx test visitor-keys
• Node 20 - nx test rule-schema-to-typescript-types
• Node 20 - nx test scope-manager
• Node 20 - nx test repo-tools
• Node 20 - nx test parser
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test eslint-plugin-tslint
• Node 20 - nx test ast-spec
• Node 16 - nx test visitor-keys --coverage=false
• Node 16 - nx test typescript-estree --coverage=false
• Node 16 - nx run types:build
• Node 16 - nx test utils --coverage=false
• nx run-many --target=typecheck --parallel
• Node 16 - nx test parser --coverage=false
• Node 16 - nx test eslint-plugin-internal --coverage=false
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• nx run-many --target=lint --parallel
• Node 16 - nx test repo-tools --coverage=false
• nx run eslint-plugin:generate:configs
• Node 16 - nx test ast-spec --coverage=false
• nx run integration-tests:test
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[rubiesonthesky]

Wasn’t the plan to just remove the fixer but not the error? For me it looks like the whole error has been removed, but I could be wrong.

[JoshuaKGoldberg]

Close! 🙌

[codecov]

Codecov Report

Merging #7394 (102eefc) into main (0a1de14) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7394   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files         381      381           
  Lines       13321    13321           
  Branches     3938     3938           
=======================================
  Hits        11645    11645           
  Misses       1298     1298           
  Partials      378      378           

Flag	Coverage Δ
unittest	87.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...int-plugin/src/rules/strict-boolean-expressions.ts	98.90% <100.00%> (ø)

[JoshuaKGoldberg]

Getting closer! 🙌

[JoshuaKGoldberg]

[Bug] Ah, suggestion messages should generally to be different from the parent report. You'll want to add a new messageId for this case.

Filed eslint-community/eslint-plugin-eslint-plugin#368 to help automate enforcing this.

[JoshuaKGoldberg]

Super, thanks @kemilbeltre! 🙌