Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): update dependency marked to v6" #7429

Merged
merged 1 commit into from Aug 5, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 5, 2023

Reverts #7422

In packages/eslint-plugin/tests/docs.test.ts:

The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("marked")' call instead.
  To convert this file to an ECMAScript module, change its file extension to '.mts' or create a local package.json file with `{ "type": "module" }`.ts(1479)
module "/Users/josh/repos/typescript-eslint/node_modules/marked/lib/marked"

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit cc86205
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64ceb4b595520a000851cbfc
😎 Deploy Preview https://deploy-preview-7429--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7891a06 into main Aug 5, 2023
3 of 8 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the revert-7422-renovate/marked-6.x branch August 5, 2023 20:44
@nx-cloud
Copy link

nx-cloud bot commented Aug 5, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cc86205. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 36 targets

Sent with 💌 from NxCloud.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant