Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peer dependency #747

Closed
deser opened this issue Jul 23, 2019 · 5 comments
Closed

Fix peer dependency #747

deser opened this issue Jul 23, 2019 · 5 comments
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin working as intended Issues that are closed as they are working as intended

Comments

@deser
Copy link

deser commented Jul 23, 2019

@typescript-eslint/eslint-plugin@1.13.0 requires a peer of eslint@^5.0.0 but none is installed. You must install peer dependencies yourself.

@deser deser added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Jul 23, 2019
@alexkulikov101
Copy link

You can try to delete folder node modules. And install again " npm i"

@bradzacher bradzacher added working as intended Issues that are closed as they are working as intended and removed triage Waiting for maintainers to take a look labels Jul 23, 2019
@bradzacher
Copy link
Member

we do not have a dependency on the package, we have a peer dependency on the package. This is on purpose.

You are expected to install and manage your own installation of eslint, because we are a plugin of eslint. If every eslint plugin had a hard dependency on eslint at a different version, your node_modules folder would get polluted with extra conflicting installs of eslint.

More reading: https://nodejs.org/es/blog/npm/peer-dependencies/

@deser
Copy link
Author

deser commented Jul 23, 2019

ok thx

@crhistianramirez
Copy link

@bradzacher does typescript-eslint not support version 6+ of eslint? Just wondering if the peer dependency should be >=5.0.0 instead of ^5.0.0

@bradzacher
Copy link
Member

#735

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin working as intended Issues that are closed as they are working as intended
Projects
None yet
Development

No branches or pull requests

4 participants