Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix is identifier token typed as Keyword #750

Merged
merged 1 commit into from Jul 24, 2019

Conversation

mrm-rideos
Copy link
Contributor

Fixes #749

As in #681 (and quoting from that PR), the is keyword wasn't correctly handled in the parser with respect to variable names, so the token it created was typed as Keyword instead of Identifier.

I suppose there are other such keywords that are also valid identifiers, but I'm not sure where to find the complete list.

@bradzacher
Copy link
Member

thanks for this!

@bradzacher bradzacher merged commit 35dec52 into typescript-eslint:master Jul 24, 2019
@bradzacher bradzacher added the bug Something isn't working label Aug 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parsing for contextual keyword is
2 participants