fix(eslint-plugin): [key-spacing] consider properties with parens and comments

[auvred]

PR Checklist

• Addresses an existing open issue: fixes Bug: [@typescript-eslint/key-spacing] False-positive for class types surrounded by parentheses #7469
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

typeStart should actually start at the first token after the colon, not after the typeAnnotation.typeAnnotation.loc.start.column

📸

[typescript-eslint]

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	a0fd459
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64f34a6f7a49110008ea84f8
😎 Deploy Preview	https://deploy-preview-7525--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Merging #7525 (a0fd459) into main (4899b95) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7525   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         387      387           
  Lines       13401    13401           
  Branches     3962     3962           
=======================================
  Hits        11690    11690           
  Misses       1327     1327           
  Partials      384      384           

Flag	Coverage Δ
unittest	87.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
packages/eslint-plugin/src/rules/key-spacing.ts	99.30% <100.00%> (ø)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a0fd459. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 40 targets

• nx test eslint-plugin --coverage=false
• Node 20 - nx test eslint-plugin
• Node 16 - nx test eslint-plugin --coverage=false
• nx build website
• nx test eslint-plugin-tslint --coverage=false
• nx run types:build
• nx run repo-tools:postinstall-script
• nx test typescript-estree --coverage=false
• Node 20 - nx test visitor-keys
• Node 20 - nx run types:build
• nx test eslint-plugin-internal --coverage=false
• Node 20 - nx run repo-tools:postinstall-script
• Node 20 - nx test rule-schema-to-typescript-types
• Node 20 - nx test parser
• Node 20 - nx test type-utils
• Node 20 - nx test repo-tools
• Node 20 - nx test utils
• Node 20 - nx test scope-manager
• Node 20 - nx test typescript-estree
• Node 20 - nx test eslint-plugin-tslint
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test ast-spec
• nx run-many --target=typecheck --parallel
• nx run-many --target=lint --parallel
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• nx run integration-tests:test
• Node 16 - nx run types:build
• Node 16 - nx test repo-tools --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test parser --coverage=false
• Node 16 - nx run repo-tools:postinstall-script
• Node 16 - nx test utils --coverage=false
• Node 16 - nx test visitor-keys --coverage=false
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx test ast-spec --coverage=false
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• Node 16 - nx test typescript-estree --coverage=false
• nx run eslint-plugin:generate:configs
• Node 16 - nx test eslint-plugin-internal --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

Looks good, thanks! Just a bit more testing and we should be good to go I think.

[JoshuaKGoldberg]

Swell, thanks!

[oliveryasuna]

What version will this fix be released with?

[JoshuaKGoldberg]

https://typescript-eslint.io/users/releases