Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [prefer-readonly] TypeError when having computed member expression #761

Merged
merged 2 commits into from Jul 25, 2019
Merged

fix(eslint-plugin): [prefer-readonly] TypeError when having computed member expression #761

merged 2 commits into from Jul 25, 2019

Conversation

eranshabi
Copy link
Contributor

this fixes #752

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #761 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files         112      112           
  Lines        4787     4787           
  Branches     1331     1331           
=======================================
  Hits         4515     4515           
  Misses        157      157           
  Partials      115      115
Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/prefer-readonly.ts 99% <100%> (ø) ⬆️

bradzacher
bradzacher approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for your contribution!

@bradzacher bradzacher merged commit 211b1b5 into typescript-eslint:master Jul 25, 2019
@bradzacher bradzacher added the bug Something isn't working label Aug 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[prefer-readonly] TypeError: Cannot read property 'text' of undefined
2 participants
@eranshabi @bradzacher