feat(eslint-plugin): [no-restricted-imports] support import = require

[Josh-Cena]

PR Checklist

• Addresses an existing open issue: fixes [no-restricted-imports] No way to use this rule with import = require() syntax. #2563
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	f9befaf
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/652efcc1e4c1ef00085765fa
😎 Deploy Preview	https://deploy-preview-7709--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f9befaf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 19 targets

• nx test eslint-plugin --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run types:build
• nx run repo-tools:postinstall-script
• nx test visitor-keys --coverage=false
• nx test typescript-estree --coverage=false
• nx test type-utils --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• nx test utils --coverage=false
• nx test scope-manager --coverage=false
• nx test repo-tools --coverage=false
• nx test parser --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test ast-spec --coverage=false
• nx run-many --target=typecheck --parallel
• nx run-many --target=lint --parallel
• nx run integration-tests:test
• nx run eslint-plugin:generate:configs
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

Swell, LGTM!

I think this is a breaking change and blocked on going into our next major release?

[JoshuaKGoldberg]

[Praise] Yes! I've started souring on extension docs that don't explicitly say what gets added.

[JoshuaKGoldberg]

[Cleanup] Nit: there's a teeny bit of duplication with calling !isAllowedTypeImportPath(importSource) && !isAllowedTypeImportPattern(importSource). Maybe worth a helper function? It's only two places, so maybe not...

[Josh-Cena]

I don't think this qualifies as a breaking change (if people really think so it can be behind an option). We usually don't automatically categorize "more errors" as breaking change, especially in the case where an error should be highly expected and the lack of one can only be explained as a bug/oversight.

[JoshuaKGoldberg]

Yeah I think you're right. In theory, if a lot of devs still used import = require syntax, then I think this'd be more debatable. But it's not a super-used feature.

🚀 ship it!