Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [member-naming] should match constructor args #771

Merged
merged 7 commits into from Aug 19, 2019
Merged

feat(eslint-plugin): [member-naming] should match constructor args #771

merged 7 commits into from Aug 19, 2019

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Jul 29, 2019 •
edited by bradzacher

Fixes #765

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@a-tarasyuk a-tarasyuk force-pushed the bug/765-member-naming-should-match-constructor-args branch 7 times, most recently from 55268dc to f66da5f Compare July 29, 2019 14:02
@a-tarasyuk a-tarasyuk force-pushed the bug/765-member-naming-should-match-constructor-args branch from f66da5f to 8e2dde4 Compare July 29, 2019 14:45
@bradzacher
Copy link
Member

LGTM! Thanks for fixing this.

@bradzacher bradzacher added 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready bug Something isn't working enhancement New feature or request and removed 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready bug Something isn't working labels Jul 29, 2019
@bradzacher bradzacher changed the title fix(eslint-plugin): [member-naming] should match constructor args feat(eslint-plugin): [member-naming] should match constructor args Jul 29, 2019
@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Jul 29, 2019
@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #771 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage   94.15%   94.16%   +0.01%     
==========================================
  Files         113      113              
  Lines        4860     4870      +10     
  Branches     1351     1355       +4     
==========================================
+ Hits         4576     4586      +10     
  Misses        163      163              
  Partials      121      121
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/member-naming.ts 100% <100%> (ø) ⬆️

@JamesHenry JamesHenry merged commit b006667 into typescript-eslint:master Aug 19, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[member-naming] Should match constructor args
3 participants
@a-tarasyuk @bradzacher @JamesHenry