Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-shadow] fix static class generics for class expressions #7724

Conversation

peanutenthusiast
Copy link
Contributor

PR Checklist

Overview

This PR adds an extra check for whether the parent of a type parameter declaration is a Class Expression

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @peanutenthusiast!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit 0cdc6d5
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6524c442d740ee0008977f36

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious. Thanks! ✨

@JoshuaKGoldberg JoshuaKGoldberg merged commit e5ea1d0 into typescript-eslint:main Oct 11, 2023
42 of 47 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-shadow] 'T' in static method is already declared in upper scope when class is in a factory function
2 participants