Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [naming-convention] allow PascalCase for imports #7841

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds 'PascalCase' alongside 'camelCase' to the allowed formats for imports. This should allow the majority of community standards, such as import * as React from "react".

Funny that out of the >15,000 (!) generated unit tests for this rule, none were impacted by this change to defaults.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5df017f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/653a369b6bcbda0008fade21
😎 Deploy Preview https://deploy-preview-7841--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7ad86ee into typescript-eslint:main Oct 26, 2023
46 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the naming-convention-default-options-import-pascal-too branch October 26, 2023 14:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants