Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [ban-ts-comments] suggest ts-expect-error over ts-ignore #7849

Merged
merged 2 commits into from Oct 30, 2023

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Oct 27, 2023

PR Checklist

Overview

Updates error message and adds a suggestion to replace ts-ignore with ts-expect-error, as long as the option for banning ts-expect-error is not set to true.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @NotWoods!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0a64ad1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65400c92c769220008c9833f
😎 Deploy Preview https://deploy-preview-7849--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall - and love the thorough tests! Just the one point, what do you think?

packages/eslint-plugin/src/rules/ban-ts-comment.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Oct 30, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cartoonish skeleton with an oversized glowing jack-o-lantern head, dancing in a nighttime cemetery

@JoshuaKGoldberg JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5e73a48 into typescript-eslint:main Oct 30, 2023
45 of 46 checks passed
@NotWoods NotWoods deleted the ts-ignore-suggestion branch October 31, 2023 01:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [ban-ts-comment] Autofix ts-ignore to ts-expect-error depending on options
2 participants