fix(eslint-plugin): [no-unused-vars] handle logical assignment

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-unused-vars] Conditional assignments are not counted as variable usages #7745
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	fcb510a
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/653fa87f2220440008f2f623
😎 Deploy Preview	https://deploy-preview-7854--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 94 (🔴 down 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fcb510a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 19 targets

• nx test eslint-plugin --coverage=false
• nx test visitor-keys --coverage=false
• nx run types:build
• nx test parser --coverage=false
• nx test ast-spec --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test utils --coverage=false
• nx run repo-tools:postinstall-script
• nx test scope-manager --coverage=false
• nx test type-utils --coverage=false
• nx test typescript-estree --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• nx test repo-tools --coverage=false
• nx run-many --target=typecheck --parallel
• nx run-many --target=lint --parallel
• nx run integration-tests:test
• nx run eslint-plugin:generate:configs
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

Looks great to me, thanks! No blocking changes on my end - just raising a question or two on the readability. If you don't have time or interest, no worries, we can merge.

[JoshuaKGoldberg]

[Proofreading] Just nitpicking a bit: @param operator The operator gives no new information and just takes up space.

• I wrote a lint rule for this 😄 https://github.com/JoshuaKGoldberg/are-docs-informative -> https://github.com/gajus/eslint-plugin-jsdoc/blob/aefceca7413ac0263ed1b58127fff4efca89de4f/docs/rules/informative-docs.md#readme.
• Filed Repo: Bring in eslint-plugin-jsdoc recommended-typescript-error preset #7855 to lint for it automatically

Suggested change

* @param operator The operator

[JoshuaKGoldberg]

[Style] Just curious, is it a strong preference on your end to make this a function? I can see an advantage of it being a bit more natural to read in the isUsedVariable function, but it's a lot more lines this way.

I'm not particularly passionate about the issue, but would prefer it just be inlined (unless you have strong feelings).

[yeonjuan]

Thanks. I think the code reads well enough without the function, I'll change it.

[Josh-Cena]

LGTM