Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-qualifier] handle nested namespace id #7883

Merged
merged 1 commit into from Nov 11, 2023

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Nov 5, 2023

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Nov 5, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 72d579d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/654f8d9124df1200088f43dd
😎 Deploy Preview https://deploy-preview-7883--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@yeonjuan yeonjuan changed the title fix(eslint-plugin): handle nested namespace id fix(eslint-plugin): [no-unnecessary-qualifier] handle nested namespace id Nov 5, 2023
@bradzacher bradzacher added the bug Something isn't working label Nov 10, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, thanks!

Build failures are unrelated. This PR is perfect as-is.

@JoshuaKGoldberg JoshuaKGoldberg merged commit a668f5b into typescript-eslint:main Nov 11, 2023
15 of 16 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-qualifier] false positive for nested namespace
3 participants