Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Perf: Run performance comparison for ts.JSDocParsingMode.ParseForTypeInfo #7906

Open
JoshuaKGoldberg opened this issue Nov 12, 2023 · 0 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue performance Issues regarding performance

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Nov 12, 2023

Suggestion

Splitting out of https://devblogs.microsoft.com/typescript/announcing-typescript-5-3-beta/#optimizations-by-skipping-jsdoc-parsing -> #7821 (comment): we'd like to use the new JSDocParsingMode flag. But how beneficial is it, exactly? Let's run some kind of performance comparison to see.

From @bradzacher:

My original perf profiling way back when showed a decent chunk of time spent but things may have changed since then.
Note: the more important time would be the non-type-aware lint time as type info would dwarf any savings we get.

#7870 is an example of me setting up a Hyperfine comparison.

@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for maintainers to take a look performance Issues regarding performance labels Nov 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue performance Issues regarding performance
Projects
None yet
Development

No branches or pull requests

1 participant