Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [member-ordering] add accessor support for member-ordering #7927

Merged

Conversation

vilicvane
Copy link
Contributor

PR Checklist

Overview

Added new member type accessor.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @vilicvane!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9abb55c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6553814fef81030008546010
😎 Deploy Preview https://deploy-preview-7927--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@vilicvane vilicvane changed the title Add accessor support for member-ordering feat: Add accessor support for member-ordering Nov 14, 2023
@vilicvane vilicvane changed the title feat: Add accessor support for member-ordering feat: [member-ordering] add accessor support for member-ordering Nov 14, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cartoon robot growing from a head to a full body and flexing muscles

@JoshuaKGoldberg
Copy link
Member

Lint failures on main are fixed, I'll merge in. Sorry about that :)

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3c8312d into typescript-eslint:main Nov 14, 2023
44 of 45 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[member-ordering] add support for the new accessor syntax
2 participants