Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configs: extend project: true to allow tsconfig.eslint.json or custom tsconfig.*.json files #7943

Closed
2 tasks done
saltman424 opened this issue Nov 17, 2023 · 1 comment
Closed
2 tasks done
Labels
duplicate This issue or pull request already exists package: typescript-estree Issues related to @typescript-eslint/typescript-estree

Comments

@saltman424
Copy link

Before You File a Proposal Please Confirm You Have Done The Following...

Description

Currently, there are four possible values for project:

  1. true
  2. path
  3. glob pattern
  4. list of paths or glob patterns

The latter three offer a lot of flexibility, but use a fundamentally different approach than the first option. Because of that, the first one is necessary for performance in large mono-repos: #1192

However, the first one always uses tsconfig.json for linting. So if you have a large mono-repo, in order to be able to lint efficiently, you cannot dedicate tsconfig.json to building or being a base tsconfig for other tsconfig.*.json, you have to use it for linting. Before migrating to a mono-repo, my team would use tsconfig.json for building, tsconfig.lint.json for linting, and tsconfig.test.json for testing. No longer being able to do is not ideal.

I would like to propose one or both of:

  1. Adding a fifth option to the list above: { nearest: string | string[] }. E.g. project: { nearest: 'tsconfig.eslint.json' } or project: { nearest: [ 'tsconfig.json', 'tsconfig.eslint.json' ] }
  2. Modifying the default logic of true to also pick up tsconfig.eslint.json files, since that seems to be the "advised" naming convention (e.g. as seen here)

Impacted Configurations

project

Additional Info

No response

@saltman424 saltman424 added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin preset config change Proposal for an addition, removal, or general change to a preset config triage Waiting for maintainers to take a look labels Nov 17, 2023
@bradzacher bradzacher added package: typescript-estree Issues related to @typescript-eslint/typescript-estree and removed package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin preset config change Proposal for an addition, removal, or general change to a preset config labels Nov 17, 2023
@bradzacher
Copy link
Member

duplicate of #7383

@bradzacher bradzacher closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2023
@bradzacher bradzacher added duplicate This issue or pull request already exists and removed triage Waiting for maintainers to take a look labels Nov 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Development

No branches or pull requests

2 participants