Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 6.13.0 breaks the deprecation and etc ESLint plugins #8002

Closed
4 tasks done
boris-petrov opened this issue Nov 28, 2023 · 2 comments
Closed
4 tasks done

Bug: 6.13.0 breaks the deprecation and etc ESLint plugins #8002

boris-petrov opened this issue Nov 28, 2023 · 2 comments
Labels
bug Something isn't working triage Waiting for maintainers to take a look

Comments

@boris-petrov
Copy link

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Issue Description

Check the reproduction. Running it leads to:

/home/boris/code/eslint-typescript-bug/foo.ts
  1:40  error  Unused eslint-disable directive (no problems were reported from 'deprecation/deprecation')

Downgrading ESLint TypeScript to 6.12.0 fixes the problem - i.e. this directive is not marked as unused (which is the correct behavior).\

The same issue also appears with the etc/no-internal rule (which is not showcased here).

Reproduction Repository Link

https://github.com/boris-petrov/eslint-typescript-bug

Repro Steps

  1. clone the repo
  2. pnpm install
  3. ./node_modules/.bin/eslint --cache --max-warnings=0 --report-unused-disable-directives .

Versions

package version
@typescript-eslint/eslint-plugin 6.13.0
@typescript-eslint/parser 6.13.0
@typescript-eslint/scope-manager 6.13.0
@typescript-eslint/typescript-estree 6.13.0
@typescript-eslint/type-utils 6.13.0
@typescript-eslint/utils 6.13.0
TypeScript 5.3.2
ESLint 8.54.0
node 21.2.0
@boris-petrov boris-petrov added bug Something isn't working triage Waiting for maintainers to take a look labels Nov 28, 2023
@bradzacher
Copy link
Member

#7999

@bradzacher
Copy link
Member

The fix has been released https://github.com/typescript-eslint/typescript-eslint/releases/tag/v6.13.1

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working triage Waiting for maintainers to take a look
Projects
None yet
Development

No branches or pull requests

2 participants