Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): Accept a glob pattern for options.project #806

Merged

Conversation

teoxoy
Copy link
Contributor

@teoxoy teoxoy commented Aug 5, 2019

closes #803

I have tested this feature in my own monorepo.
Includes some misc docs fixes

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @teoxoy!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

bradzacher
bradzacher previously approved these changes Aug 6, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. LGTM.
Thanks for working on this.

@bradzacher bradzacher added the enhancement New feature or request label Aug 6, 2019
@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Aug 6, 2019
@JamesHenry
Copy link
Member

Sorry for conflicts introduced by recent merges @teoxoy - just let me know when this is synced back up and we'll get it merged, thanks a lot!

@teoxoy
Copy link
Contributor Author

teoxoy commented Aug 19, 2019

@JamesHenry Done!

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #806 into master will decrease coverage by 0.03%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
- Coverage    94.1%   94.07%   -0.04%     
==========================================
  Files         113      113              
  Lines        4906     4911       +5     
  Branches     1366     1368       +2     
==========================================
+ Hits         4617     4620       +3     
  Misses        165      165              
- Partials      124      126       +2
Impacted Files Coverage Δ
packages/typescript-estree/src/tsconfig-parser.ts 88% <ø> (ø) ⬆️
packages/typescript-estree/src/parser.ts 93.05% <60%> (-1.19%) ⬇️

@bradzacher bradzacher merged commit 9e5f21e into typescript-eslint:master Aug 19, 2019
@teoxoy teoxoy deleted the parserOptions.project-allow-glob branch August 19, 2019 17:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Accept a glob pattern for options.project
3 participants