Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): typedef shouldn't flag destructurings when variables are disabled #819

Conversation

JoshuaKGoldberg
Copy link
Member

Fixes #788.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #819 into master will decrease coverage by <.01%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
- Coverage   94.08%   94.07%   -0.01%     
==========================================
  Files         113      113              
  Lines        4917     4914       -3     
  Branches     1370     1369       -1     
==========================================
- Hits         4626     4623       -3     
  Misses        165      165              
  Partials      126      126
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/typedef.ts 95.65% <91.66%> (-0.27%) ⬇️

@bradzacher bradzacher added the bug Something isn't working label Aug 7, 2019
@bradzacher bradzacher changed the title fix: typedef shouldn't flag destructurings when variables are disabled fix(eslint-plugin): typedef shouldn't flag destructurings when variables are disabled Aug 7, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@bradzacher bradzacher merged commit 5603473 into typescript-eslint:master Aug 27, 2019
@octogonz
Copy link
Contributor

Thanks for fixing this!

@JoshuaKGoldberg JoshuaKGoldberg deleted the typedef-declarator-patterns branch August 27, 2019 18:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/typedef] objectDestructuring=false apparently not working
3 participants