Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@t-e/eslint-plugin 2.0.0-alpha.4 has an incorrect peer dependency on @t-e/parser #827

Closed
octogonz opened this issue Aug 9, 2019 · 4 comments
Labels
bug Something isn't working dependencies Issue about dependencies of the package package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@octogonz
Copy link
Contributor

octogonz commented Aug 9, 2019

When I install @typescript-eslint/eslint-plugin@canary, I get version 2.0.0-alpha.4 with this package.json:

{
  "name": "@typescript-eslint/eslint-plugin",
  "version": "2.0.0-alpha.4",
  "dependencies": {
    "@typescript-eslint/experimental-utils": "2.0.0-alpha.4",
    "eslint-utils": "^1.4.0",
    "functional-red-black-tree": "^1.0.1",
    "regexpp": "^2.0.1",
    "tsutils": "^3.14.0"
  },
  "devDependencies": {
    "@types/json-schema": "^7.0.3",
    "@types/marked": "^0.6.5",
    "chalk": "^2.4.2",
    "marked": "^0.7.0",
    "typescript": "*"
  },
  "peerDependencies": {
    "@typescript-eslint/parser": "^1.9.0",  // <====== ?
    "eslint": "^5.0.0 || ^6.0.0"
  },
  . . . 
}

The @typescript-eslint/parser package depends on a bunch of other @typescript-eslint packages, which seemingly should all be the 2.0.0-alpha.4 version.

However the peer dependency requires @typescript-eslint/parser to be ^1.9.0, and if I try to do that then I end up with conflicting versions of @typescript-eslint/experimental-utils.

Suggested fix: Change the @typescript-eslint/parser peer dependency to be the canary version.

@JamesHenry FYI

@octogonz octogonz added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Aug 9, 2019
@bradzacher bradzacher added bug Something isn't working dependencies Issue about dependencies of the package and removed triage Waiting for maintainers to take a look labels Aug 9, 2019
@JamesHenry
Copy link
Member

Thanks, yeah - lerna doesn't update the peerDeps, so every major version we have to remember to change it

@JamesHenry
Copy link
Member

@octogonz Please can you try out 2.0.0-alpha.5

@octogonz
Copy link
Contributor Author

octogonz commented Aug 9, 2019

That fixed it, thanks!

@JamesHenry BTW could we get a canary release with PR #790? That's still blocking some of our projects from moving off of TSLint.

@bradzacher
Copy link
Member

(closing for housekeeping because the original issue is resolved)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working dependencies Issue about dependencies of the package package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

No branches or pull requests

3 participants