Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0-alpha.5 seems to have same recommended rules as v1 #836

Closed
David-Else opened this issue Aug 10, 2019 · 1 comment
Closed

2.0.0-alpha.5 seems to have same recommended rules as v1 #836

David-Else opened this issue Aug 10, 2019 · 1 comment

Comments

@David-Else
Copy link

I installed the canary version:

  "devDependencies": {
    "@typescript-eslint/eslint-plugin": "^2.0.0-alpha.5",
    "@typescript-eslint/parser": "^2.0.0-alpha.0",
    "eslint": "^6.1.0"
  }

and in dist/config recommended.json is:

{
  "extends": "./configs/base.json",
  "rules": {
    "no-var": "error",
    "prefer-const": "error",
    "prefer-rest-params": "error",
    "prefer-spread": "error",
    "@typescript-eslint/adjacent-overload-signatures": "error",
    "@typescript-eslint/array-type": "error",
    "@typescript-eslint/ban-types": "error",
    "camelcase": "off",
    "@typescript-eslint/camelcase": "error",
    "@typescript-eslint/class-name-casing": "error",
    "@typescript-eslint/consistent-type-assertions": "error",
    "@typescript-eslint/explicit-function-return-type": "warn",
    "@typescript-eslint/explicit-member-accessibility": "error",
    "indent": "off",
    "@typescript-eslint/indent": "error",
    "@typescript-eslint/interface-name-prefix": "error",
    "@typescript-eslint/member-delimiter-style": "error",
    "no-array-constructor": "off",
    "@typescript-eslint/no-array-constructor": "error",
    "@typescript-eslint/no-empty-interface": "error",
    "@typescript-eslint/no-explicit-any": "warn",
    "@typescript-eslint/no-inferrable-types": "error",
    "@typescript-eslint/no-misused-new": "error",
    "@typescript-eslint/no-namespace": "error",
    "@typescript-eslint/no-non-null-assertion": "error",
    "@typescript-eslint/no-parameter-properties": "error",
    "no-unused-vars": "off",
    "@typescript-eslint/no-unused-vars": "warn",
    "no-use-before-define": "off",
    "@typescript-eslint/no-use-before-define": "error",
    "@typescript-eslint/no-var-requires": "error",
    "@typescript-eslint/prefer-namespace-keyword": "error",
    "@typescript-eslint/type-annotation-spacing": "error"
  }
}

which is identical to the current v1 version:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/src/configs/recommended.json

I am using PNPM https://github.com/pnpm/pnpm, could this be a package manager error?

PS Is v2 coming soon? :)

@bradzacher
Copy link
Member

bradzacher commented Aug 10, 2019

#729 has not been merged yet.
We're going to trim down the list a bit.
Just going to take a moment for us to find a second to discuss the changes.

V2 will come essentially once that PR is merged.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants