Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo: Incorporate void check into isNullableType? #8974

Open
kirkwaiblinger opened this issue Apr 22, 2024 · 0 comments
Open

Repo: Incorporate void check into isNullableType? #8974

kirkwaiblinger opened this issue Apr 22, 2024 · 0 comments
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for maintainers to take a look

Comments

@kirkwaiblinger
Copy link
Member

Suggestion

In https://github.com/typescript-eslint/typescript-eslint/pull/8912/files#r1572612158, the void type is treated as a nullable type for the purposes of no-unnecessary-type-assertion, the same as null and undefined would be. Consider whether checking for the void type should be incorporated into the helper method isNullableType already used for checking for the null and undefined type, and assess whether its impact on other rules that use that helper is a correct behavior change or not.

@kirkwaiblinger kirkwaiblinger added triage Waiting for maintainers to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for maintainers to take a look
Projects
None yet
Development

No branches or pull requests

1 participant