Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [unbound-method] Allow typeof expressions #904

Merged
merged 2 commits into from Aug 27, 2019

Conversation

scottohara
Copy link
Contributor

Fixes #692

Disclaimer:
I hope this is not frowned upon, but this PR relates to an issue labelled good first issue, despite the fact that I'm not a first-time contributor.

I was in two minds about potentially taking away this opportunity for a new contributor to get involved with a nice easy PR, but on the other hand, this issue is currently triggering a warning in one of my projects and I just wanted it resolved.

Apologies if this is considered bad form.

This PR allows for the case where the parent node of the unbound method is a unary typeof expression, and does not trigger an error.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @scottohara!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@bradzacher bradzacher added the bug Something isn't working label Aug 26, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Nothing frowned upon here - I marked issues as "good first issue" just to signal "easier" issues, because people had been asking for good starting points. More than happy for anyone to pick up any issue, esp if it's causing problems for them.

@bradzacher bradzacher merged commit 344bafe into typescript-eslint:master Aug 27, 2019
@scottohara scottohara deleted the unbound-method branch September 17, 2019 01:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[unbound-method] problem detected using typeof of method
2 participants