Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-inferrable-types] ignore optional properties #918

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #902

Technically in this case, it is actually a bug in no-inferrable-types.
foo?: string = 'str' is not inferrable, as the property is optional.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #918 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files         113      113           
  Lines        4916     4916           
  Branches     1369     1369           
=======================================
  Hits         4625     4625           
  Misses        165      165           
  Partials      126      126
Impacted Files Coverage Δ
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 93.1% <100%> (ø) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Aug 29, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Awesome, thanks for fixing this!

@bradzacher bradzacher merged commit a4e625f into typescript-eslint:master Aug 29, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-inferrable-types][typedef] Rules clash in 'all' config
2 participants