fix(eslint-plugin): [explicit-function-return-type] make error location smaller #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @a-tarasyuk! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint |
Codecov Report
@@ Coverage Diff @@
## master #919 +/- ##
==========================================
+ Coverage 94.08% 94.09% +0.01%
==========================================
Files 113 113
Lines 4919 4929 +10
Branches 1371 1375 +4
==========================================
+ Hits 4628 4638 +10
Misses 165 165
Partials 126 126
|
bradzacher
requested changes
Aug 30, 2019
packages/eslint-plugin/src/rules/explicit-function-return-type.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts
Outdated
Show resolved
Hide resolved
bradzacher
changed the title
bradzacher
added
bug
a-tarasyuk
force-pushed
the
feature/explicit-function-return-type-error-too-big
branch
from
576cdcc
to
e2ce982
Compare
bradzacher
approved these changes
Aug 30, 2019
bradzacher
removed
the
1 approval
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #882