Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [camelcase] add genericType option #925

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #913

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@a-tarasyuk a-tarasyuk force-pushed the feature/913-camelcase-add-generic-type-option branch from ada676b to 25870b3 Compare August 30, 2019 10:33
@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Aug 30, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #925 into master will increase coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   94.23%   94.26%   +0.02%     
==========================================
  Files         126      126              
  Lines        5377     5384       +7     
  Branches     1510     1513       +3     
==========================================
+ Hits         5067     5075       +8     
+ Misses        177      176       -1     
  Partials      133      133
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/camelcase.ts 95% <85.71%> (+4.09%) ⬆️

@a-tarasyuk a-tarasyuk closed this Oct 24, 2019
@a-tarasyuk a-tarasyuk reopened this Nov 18, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

packages/eslint-plugin/src/rules/camelcase.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/src/rules/camelcase.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Nov 21, 2019
@a-tarasyuk a-tarasyuk force-pushed the feature/913-camelcase-add-generic-type-option branch from 127d9a1 to c0ffc4f Compare November 21, 2019 12:16
@a-tarasyuk a-tarasyuk force-pushed the feature/913-camelcase-add-generic-type-option branch from c0ffc4f to acd9af3 Compare November 21, 2019 13:09
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[generic-type-naming] conflict with [camelcase]
2 participants