Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[recommended-requiring-type-checking] Add no-floating-promise by default #931

Closed
EduardoRFS opened this issue Aug 31, 2019 · 2 comments
Closed

[recommended-requiring-type-checking] Add no-floating-promise by default #931

EduardoRFS opened this issue Aug 31, 2019 · 2 comments
Labels
breaking change This change will require a new major version to be released package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin recommended-rules Discussion about recommended rule sets

Comments

@EduardoRFS
Copy link

I was looking at recommended-requiring-type-checking and did notice that it doesn't use no-floating-promise on it, but it seem weird, as it includes some rules of the same kind that make better usage of promises and avoid weird things. await-thenable, no-misused-promises and require-await.

Adding no-floating-promise would just continuous the idea of this and improve a better default for most use cases, especially when new developers who aren't experienced on JavaScript try to use the language.
@EduardoRFS EduardoRFS added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Aug 31, 2019
@bradzacher bradzacher added recommended-rules Discussion about recommended rule sets and removed triage Waiting for maintainers to take a look labels Aug 31, 2019
@joeytwiddle
Copy link

Agreed, not handling promises is a common source of problems with inexperienced developers on our codebase. This rule helps a lot!

I think it would be useful to have this enabled by default. (Teams can always opt out if they want.)

@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Sep 30, 2019
@bradzacher bradzacher added this to the 3.0.0 milestone Sep 30, 2019
@bradzacher
Copy link
Member

See recommended discussion in #1423

@bradzacher bradzacher removed this from the 3.0.0 milestone Jan 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin recommended-rules Discussion about recommended rule sets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joeytwiddle @EduardoRFS @bradzacher