Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [efrt] allowExpressions - check functions in class field properties #952

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #950

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@bradzacher bradzacher changed the title feat(fix): handle functions in class field properties fix(eslint-plugin): [efrt] allowExpressions - check functions in class field properties Sep 6, 2019
@bradzacher bradzacher added the bug Something isn't working label Sep 6, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy as. LGTM.
Thanks for doing this!

@bradzacher bradzacher merged commit f1059d8 into typescript-eslint:master Sep 7, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[explicit-function-return-type] allowExpressions should not allow methods
2 participants