Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): ImportDeclaration.specifier to Literal #974

Conversation

pablobirukov
Copy link
Contributor

According to the spec, ImportDeclaration.source should have type Literal

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @pablobirukov!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #974 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
- Coverage   94.13%   94.13%   -0.01%     
==========================================
  Files         115      115              
  Lines        5017     5016       -1     
  Branches     1403     1403              
==========================================
- Hits         4723     4722       -1     
  Misses        166      166              
  Partials      128      128
Impacted Files Coverage Δ
.../eslint-plugin/src/rules/triple-slash-reference.ts 89.65% <100%> (-0.35%) ⬇️

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this

@bradzacher bradzacher added the bug Something isn't working label Sep 13, 2019
@bradzacher bradzacher changed the title fix(typescript-estree): narrow ImportDeclaration.specifier's to Literal fix(typescript-estree): ImportDeclaration.specifier to Literal Sep 13, 2019
@bradzacher bradzacher merged commit 2bf8231 into typescript-eslint:master Sep 13, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants