Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [cons-type-assns] handle namespaced types #975

Merged
merged 2 commits into from Sep 17, 2019
Merged

fix(eslint-plugin): [cons-type-assns] handle namespaced types #975

merged 2 commits into from Sep 17, 2019

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #629

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Sep 13, 2019 •
edited

Codecov Report

Merging #975 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #975   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files         115      115           
  Lines        5016     5016           
  Branches     1403     1403           
=======================================
  Hits         4722     4722           
  Misses        166      166           
  Partials      128      128
Impacted Files Coverage Δ
...int-plugin/src/rules/consistent-type-assertions.ts 87.09% <100%> (ø) ⬆️

@a-tarasyuk a-tarasyuk force-pushed the bug/629-consistent-type-assertion-false-positive-if-type-is-namespaced branch from a1606b8 to 67b4f4e Compare September 13, 2019 12:03
@bradzacher bradzacher added the bug Something isn't working label Sep 16, 2019
bradzacher
bradzacher approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this

@bradzacher bradzacher changed the title fix(eslint-plugin): false positive if type is namespaced fix(eslint-plugin): [cons-type-assns] handle namespaced types Sep 17, 2019
@bradzacher bradzacher merged commit c3c8b86 into typescript-eslint:master Sep 17, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[consistent-type-assertion] False positive if type is namespaced
2 participants
@a-tarasyuk @bradzacher